[PATCH] D81648: MIR Statepoint refactoring. Part 4: ISEL changes.

Philip Reames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 7 15:15:29 PDT 2020


reames added a comment.

Required Change - Please introduce a runtime flag which controls how many values are handled via vregs.  Default this value to zero.  This will remove all existing test diffs; if it doesn't you have a bug.  Then introduce a new test file, optional copied from an existing one, called statepoint-gc-regs.ll which enumerates sufficient coverage for the new feature.

This is not a suggestion, it is a requirement.  I specifically need to see a zero diff in the existing tests to have confidence in the changes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81648/new/

https://reviews.llvm.org/D81648





More information about the llvm-commits mailing list