[PATCH] D82927: Intergerate Loop Peeling into Loop Fusion

Sidharth Baveja via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 7 14:00:14 PDT 2020


sidbav marked an inline comment as done.
sidbav added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/LoopFuse.cpp:124
+
+static cl::opt<unsigned> FusionPeelMaxCount(
+    "loop-fusion-peel-max-count", cl::init(3), cl::Hidden,
----------------
bmahjour wrote:
> We only really need one option to control peeling for loop fusion. You can remove `loop-fusion-peel` and change the default for this threshold to 0. I don't know what others feel about this, but I'd rather have shorter commands when possible. 
I agree with this idea, setting up the option like this will allow for this option to serve both purposes, of enabling peeling for fusion, and specifying the max value for fusion. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82927/new/

https://reviews.llvm.org/D82927





More information about the llvm-commits mailing list