[PATCH] D83335: [ScheduleDAGRRList] Use std::*_heap() to keep candidate queue a heap.

Tue Jul 7 13:24:14 PDT 2020

fhahn planned changes to this revision.
fhahn added a comment.

In D83335#2137150 <https://reviews.llvm.org/D83335#2137150>, @efriedma wrote:

> I'm concerned that the behavior of queues with multiple candidates with the same score might not be consistent across compilers.  (This is similar to using llvm::sort when you really need std::stable_sort.)

It looks like the comperators try hard to break ties between candidates with the same score (via an increasing `NodeQueueId`) but I think I noticed cases where there we still visit candidates in a slightly different order. I'll take a closer look

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83335/new/

https://reviews.llvm.org/D83335