[PATCH] D83021: [Inliner] Don't skip inlining alwaysinline in optnone functions

Arthur Eubanks via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 7 12:59:08 PDT 2020


aeubanks added a comment.

In D83021#2128775 <https://reviews.llvm.org/D83021#2128775>, @aeubanks wrote:

> Actually, I'm wondering if the NPM inliner properly handles alwaysinline in all cases? I don't see any other references to "alwaysinline" in Inliner.cpp (besides some legacy passes).


jyknight pointed me to llvm::getAttributeBasedInliningDecision() where alwaysinline is handled.
It still seems a little weird to me that alwaysinline isn't a separate pass under the -O1/-O2/-O3 pipelines and would make opt-bisect always run the inliner pass (once it's implemented in NPM). But this will do for now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83021/new/

https://reviews.llvm.org/D83021





More information about the llvm-commits mailing list