[PATCH] D83336: [flang] Support for image selectors

Pete Steinfeld via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 7 12:34:27 PDT 2020


PeteSteinfeld created this revision.
PeteSteinfeld added reviewers: klausler, tskeith.
Herald added a reviewer: DavidTruby.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

This change implements support for image selectors and image selector
specifications as described in section 9.6.

In check-coarray[.h,cpp] I changed the `Leave()` function for
`parser::ImageSelectorSpec` to take a `parser::ImageSelector`, which
contains a list of image selector specifications.  This allows us to
detect when the same specification is used more than once.  I also added
code to analyze the expressions for the image selector specifications to
expression.cpp and a test for all of the conditions to check at
compile-time.

Note that we do not check at compile-time to see if the value of the
cosubscripts are within the specified cobounds.  We also do not check anything
related to selecting a valid team.  We also do not check that the denotation of
the `stat-variable` is not dependent on the evaluation of an entity in the
same statement.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D83336

Files:
  flang/include/flang/Parser/tools.h
  flang/lib/Parser/tools.cpp
  flang/lib/Semantics/check-coarray.cpp
  flang/lib/Semantics/check-coarray.h
  flang/lib/Semantics/expression.cpp
  flang/test/Semantics/resolve94.f90

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D83336.276182.patch
Type: text/x-patch
Size: 9736 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200707/1f4f3624/attachment.bin>


More information about the llvm-commits mailing list