[PATCH] D83056: [NFC] Separate the Loop Peeling Utilities from the Loop Unrolling Utilities

Michael Kruse via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 7 12:10:43 PDT 2020


Meinersbur added inline comments.


================
Comment at: llvm/lib/Transforms/Utils/LoopPeel.cpp:50
 
-#define DEBUG_TYPE "loop-unroll"
+#define DEBUG_TYPE "loop-peel"
 
----------------
fhahn wrote:
> I am not sure about this change. Currently peeling is integrated in loop-unroll and remarks/debug can be filtered by loop-unroll, but now we will generate remarks for `loop-unroll` and `loop-peel` when running `-loop-unroll`.
Isn't it actually better since you can now filter `-debug-only=loop-unroll`, respectively `-debug-only=loop-peel` depending on what you want to look at?

Note: `-Rpass=` remarks use the pass name, not `DEBUG_TYPE`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83056/new/

https://reviews.llvm.org/D83056





More information about the llvm-commits mailing list