[PATCH] D83311: [CodeMoverUtils] Add optional data dependence checks using MSSA

[rithik sharma via Phabricator via llvm-commits]

RithikSharma marked an inline comment as done.
RithikSharma added inline comments.


================
Comment at: llvm/unittests/Transforms/Utils/CodeMoverUtilsTest.cpp:513
                                        *CI_safecall->getNextNode(), DT, &PDT,
-                                       &DI));
+                                       &DI, &MSSAU));
+        EXPECT_TRUE(isSafeToMoveBefore(*CI_safecall->getPrevNode(),
----------------
Whitney wrote:
> change all the existing ones to `&DI, nullptr))` to make sure you are testing `DI`.
Sure but even when we give preference to DI?

```
 if (DI)
    return isDependenceSafe(I, *DI, InstsToCheck);
  else if (MSSAU)
    return isDependenceSafe(I, *MSSAU, InstsToCheck);
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83311/new/

https://reviews.llvm.org/D83311