[compiler-rt] 8a8d6e2 - Revert "Temporarily disable the following failing tests on Darwin:"

Dan Liew via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 7 10:16:13 PDT 2020


Author: Dan Liew
Date: 2020-07-07T10:15:46-07:00
New Revision: 8a8d6e2b727112fafc52477acaf25affb62b6e65

URL: https://github.com/llvm/llvm-project/commit/8a8d6e2b727112fafc52477acaf25affb62b6e65
DIFF: https://github.com/llvm/llvm-project/commit/8a8d6e2b727112fafc52477acaf25affb62b6e65.diff

LOG: Revert "Temporarily disable the following failing tests on Darwin:"

This reverts commit f3a089506fdcc4a1d658697009572c93e00c4373.

888951aaca583bcce85b42ea6166416db8f96fe0 introduced a fix that
should make the disabled tests work again.

rdar://problem/62141412

Added: 
    

Modified: 
    compiler-rt/lib/asan/tests/asan_test.cpp

Removed: 
    


################################################################################
diff  --git a/compiler-rt/lib/asan/tests/asan_test.cpp b/compiler-rt/lib/asan/tests/asan_test.cpp
index 83b0b0e8d33e..edc98ed18520 100644
--- a/compiler-rt/lib/asan/tests/asan_test.cpp
+++ b/compiler-rt/lib/asan/tests/asan_test.cpp
@@ -588,9 +588,6 @@ NOINLINE void TouchStackFunc() {
     A[i] = i*i;
 }
 
-// Disabled due to rdar://problem/62141412
-#if !(defined(__APPLE__) && defined(__i386__))
-
 // Test that we handle longjmp and do not report false positives on stack.
 TEST(AddressSanitizer, LongJmpTest) {
   static jmp_buf buf;
@@ -600,7 +597,6 @@ TEST(AddressSanitizer, LongJmpTest) {
     TouchStackFunc();
   }
 }
-#endif
 
 #if !defined(_WIN32)  // Only basic longjmp is available on Windows.
 NOINLINE void UnderscopeLongJmpFunc1(jmp_buf buf) {
@@ -662,8 +658,6 @@ TEST(AddressSanitizer, UnderscopeLongJmpTest) {
   }
 }
 
-// Disabled due to rdar://problem/62141412
-#if !(defined(__APPLE__) && defined(__i386__))
 TEST(AddressSanitizer, SigLongJmpTest) {
   static sigjmp_buf buf;
   if (!sigsetjmp(buf, 1)) {
@@ -674,8 +668,6 @@ TEST(AddressSanitizer, SigLongJmpTest) {
 }
 #endif
 
-#endif
-
 // FIXME: Why does clang-cl define __EXCEPTIONS?
 #if defined(__EXCEPTIONS) && !defined(_WIN32)
 NOINLINE void ThrowFunc() {


        


More information about the llvm-commits mailing list