[PATCH] D83181: [x86] improve codegen for non-splat bit-masked vector compare and select (PR46531)

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 7 09:32:39 PDT 2020


RKSimon accepted this revision.
RKSimon added a comment.
This revision is now accepted and ready to land.

LGTM - cheers



================
Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:40269
+      SmallVector<int, 32> ShlVals;
+      for (unsigned i = 0; i != VT.getVectorNumElements(); ++i) {
+        auto *MaskVal = cast<ConstantSDNode>(Mask.getOperand(i));
----------------
unsigned i = 0, e = VT.getVectorNumElements(); i != e; ++i


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83181/new/

https://reviews.llvm.org/D83181





More information about the llvm-commits mailing list