[PATCH] D83100: [PPC][GlobalISel] Add initial GlobalIsel infrastructure

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 7 09:14:03 PDT 2020


arsenm added a comment.

In D83100#2136392 <https://reviews.llvm.org/D83100#2136392>, @kbarton wrote:

> In D83100#2134249 <https://reviews.llvm.org/D83100#2134249>, @tschuett wrote:
>
> > Pardon my cmake, but don't you need a CMakeLists.txt in the GISel sub-directory?
>
>
> I thought I would too, but I added GISel/ prefix to the CMake in the PowerPC directory, which works. 
>  This is the way it was done in the Aarch64 patch that did the refactoring.
>
> That said, I am by no means a cmake expert, so if having a separate CMakeLists.txt file in the GISel directory is "better",  I can add one there also.


It's not a separate library, so it's not better. Things are not layered to make this possible


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83100/new/

https://reviews.llvm.org/D83100





More information about the llvm-commits mailing list