[PATCH] D82820: [InstCombine] Fix mismatched attribute lists for combined calls

Vitaly Buka via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 7 01:32:50 PDT 2020


vitalybuka added a comment.

LGTM



================
Comment at: llvm/lib/Transforms/Utils/SimplifyLibCalls.cpp:1833
+                             Attrs.getAttributes(AttributeList::ReturnIndex))
+              .addAttributes(
+                  B.getContext(), AttributeList::FirstArgIndex + 0,
----------------
does this assign attributes of x to the 1.0 constant?
why?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82820/new/

https://reviews.llvm.org/D82820





More information about the llvm-commits mailing list