[PATCH] D83232: [llvm-readobj] - Don't abort when dumping dynamic relocations when an object has both REL and RELA.

Tue Jul 7 01:29:36 PDT 2020

jhenderson added inline comments.

================
Comment at: llvm/test/tools/llvm-readobj/ELF/broken-dynamic-reloc.test:499-512
+      - Tag:   DT_RELA
+        Value: 0x0
+      - Tag:   DT_RELASZ
+        Value: 0x18
+      - Tag:   DT_RELAENT
+        Value: 0x18
+      - Tag:   DT_REL
----------------
The input here is a little subtle, i.e. reusing the same data for both REL and RELA relocations. Perhaps it would be clearer to have them point at different sections? If that's not possible, it might be worth pointing out how this works in a comment.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83232/new/

https://reviews.llvm.org/D83232