[PATCH] D83208: [llvm-readobj] - Refactor ELFDumper<ELFT>::getStaticSymbolName.

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 7 00:13:47 PDT 2020


jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:1135
+std::string ELFDumper<ELFT>::getStaticSymbolName(uint32_t Index) const {
+  auto ReportWarn = [&](Error E) -> std::string {
+    this->reportUniqueWarning(
----------------
Either simply `Warn` or `ReportWarning`, I think.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83208/new/

https://reviews.llvm.org/D83208





More information about the llvm-commits mailing list