[PATCH] D82982: [openmp] Move isAllowedClauseForDirective to tablegen + add clause version to OMP.td

[Valentin Clement via Phabricator via llvm-commits]

clementval added inline comments.


================
Comment at: llvm/include/llvm/Frontend/Directive/DirectiveBase.td:69
+
+  // Mininum version number where this clause is valid in the list.
+  int minVersion = min;
----------------
jdenny wrote:
> clementval wrote:
> > jdenny wrote:
> > > What does "the list" refer to?
> > I updated the comment and dropped the list. I think it is clearer now.
> I don't see the change.
Forgot this one. Sorry. 


================
Comment at: llvm/utils/TableGen/DirectiveEmitter.cpp:296
+
+  OS << "\n"; // Empty line at end of file
 }
----------------
jdenny wrote:
> clementval wrote:
> > jdenny wrote:
> > > Why is an empty line needed?
> > Just to be consistent with clang-format in the generated file.
> It's surprising that clang-format would require an empty line at the end of the file.  Any idea why?
Sorry, it is not clang-format but Phabricator which signal a missing empty line at end of file. This is not mandatory and can be removed. The file is generated. I just wanted to be consistent with the style. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82982/new/

https://reviews.llvm.org/D82982