[PATCH] D83245: [PowerPC][Power10] Exploit the xxsplti32dx instruction when lowering VECTOR_SHUFFLE.

[Anil Mahmud via Phabricator via llvm-commits]

anil9 added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:9827
+
+  // Check that the shuffle mask matches the semantics the XXSPLTI32DX.
+  // XXSPLTI32DX can insert 4 byte chunks from the constant splat C into:
----------------
semantics the -> semantics of the


================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.h:105
 
+    /// XXSPLTI32DX - The PPC XXSPLTI32DX instruction.
+    XXSPLTI32DX,
----------------
nit : the other ones seem to have a extra line with ///


================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.h:1278
+    /// handled by the XXSPLTI32DX instruction introduced in ISA 3.1.
+    SDValue lowerToXXSPLTI32DX(ShuffleVectorSDNode *N, SelectionDAG &DAG) const;
+
----------------
nit : 
///  otherwise return the default SDValue.  ???


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83245/new/

https://reviews.llvm.org/D83245