[PATCH] D82972: [DebugInfo] Introduce GNU macro extension entry encodings

David Stenberg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 6 12:54:10 PDT 2020


dstenb added a comment.

In D82972#2127215 <https://reviews.llvm.org/D82972#2127215>, @SouraVX wrote:

> Do we really need this ?, Please have a look at https://sourceware.org/legacy-ml/gdb-patches/2017-02/msg00528.html
>  IMO, it would be unwise to commit it till the discussion thread in D82975 <https://reviews.llvm.org/D82975> converges ?


As I write in the commit message this patch is not strictly needed, but I think it makes the code more clear.

I'll wait with this patch until we decide in D82975 <https://reviews.llvm.org/D82975>.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82972/new/

https://reviews.llvm.org/D82972





More information about the llvm-commits mailing list