[PATCH] D81939: [deadargelim] Attach dbg info to the insert/extractvalue instructions

Djordje Todorovic via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 6 12:53:57 PDT 2020


djtodoro marked an inline comment as done.
djtodoro added inline comments.


================
Comment at: llvm/test/Transforms/DeadArgElim/multdeadretval.ll:7
 
+; RUN: opt < %s -enable-debugify=synthetic -deadargelim -S 2>&1 \
+; RUN:     | FileCheck %s -check-prefix=DEBUG
----------------
vsk wrote:
> I recommend copying this test, modifying it to include debug info, and dropping the -enable-debugify=synthetic part. This bugfix doesn't need to depend on the debugify original mode patchset. Also, the hardcoded checks for DILocation line numbers will make this test hard to modify, so if we want to check specific synthetic line numbers I think we'd be better served by a dedicated test.
It makes sense to me! Thanks!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81939/new/

https://reviews.llvm.org/D81939





More information about the llvm-commits mailing list