[PATCH] D83185: [Attributor] Introduce Attribute seed allow list.

Kuter Dinel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 6 12:53:53 PDT 2020


kuter marked an inline comment as done.
kuter added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/Attributor.cpp:1460
+    return true;
+  return std::count(SeedAllowList.begin(), SeedAllowList.end(), AA.getName());
+}
----------------
sstefan1 wrote:
> would it make sense to make this always check lower case names, to avoid mistakes?
Since the name is usually the name of the class that defines the attribute, 
I think it makes for sense the use the name as is.
 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83185/new/

https://reviews.llvm.org/D83185





More information about the llvm-commits mailing list