[PATCH] D83138: [ELF][ARM] Represent R_ARM_LDO32 as R_DTPREL instead of R_ABS

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 6 12:53:29 PDT 2020


grimar added inline comments.


================
Comment at: lld/ELF/Relocations.cpp:241
   // Local-Dynamic relocs can be relaxed to Local-Exec.
-  if (expr == R_DTPREL && !config->shared) {
+  if (expr == R_DTPREL && canRelax && !config->shared) {
     c.relocations.push_back(
----------------
I've noticed that `canRelax` is always used with `&& !config->shared` now.
So can it be:

```
  bool canRelax = !config->shared && config->emachine != EM_ARM &&
                  config->emachine != EM_HEXAGON &&
                  config->emachine != EM_RISCV;
```





Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83138/new/

https://reviews.llvm.org/D83138





More information about the llvm-commits mailing list