[PATCH] D83192: Fix off by one error in Bitfields

[Guillaume Chatelet via Phabricator via llvm-commits]

This revision was not accepted when it landed; it landed in state "Needs Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rG4c0a965c0926: Fix off by one error in Bitfields (authored by gchatelet).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83192/new/

https://reviews.llvm.org/D83192

Files:
  llvm/include/llvm/ADT/Bitfields.h


Index: llvm/include/llvm/ADT/Bitfields.h
===================================================================
--- llvm/include/llvm/ADT/Bitfields.h
+++ llvm/include/llvm/ADT/Bitfields.h
@@ -227,7 +227,7 @@
     static constexpr unsigned Shift = Offset;
     static constexpr unsigned Bits = Size;
     static constexpr unsigned FirstBit = Offset;
-    static constexpr unsigned LastBit = Shift + Bits;
+    static constexpr unsigned LastBit = Shift + Bits - 1;
 
   private:
     template <typename, typename> friend struct bitfields_details::Impl;
@@ -273,7 +273,7 @@
 
   /// Returns whether the two bitfields share common bits.
   template <typename A, typename B> static constexpr bool isOverlapping() {
-    return A::LastBit > B::FirstBit && B::LastBit > A::FirstBit;
+    return A::LastBit >= B::FirstBit && B::LastBit >= A::FirstBit;
   }
 };
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D83192.275604.patch
Type: text/x-patch
Size: 852 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200706/2cf91992/attachment.bin>