[PATCH] D83153: [DAGCombiner] Prevent regression in isMulAddWithConstProfitable

Ben Shi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 6 12:53:23 PDT 2020


benshi001 marked an inline comment as done.
benshi001 added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:15750
+    // are too large.
+    if (ConstNode.getScalarValueSizeInBits() > 8 * sizeof(int64_t))
+      return true;
----------------
MaskRay wrote:
> This should be `>=`
This should be >, not >=, otherwise riscv64/aarch64 will still fall to regression for i64 add-mul.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83153/new/

https://reviews.llvm.org/D83153





More information about the llvm-commits mailing list