[PATCH] D82923: introducing llvm-libtool-darwin

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 6 12:53:22 PDT 2020


jhenderson added inline comments.


================
Comment at: llvm/test/tools/llvm-libtool-darwin/invalid-input-output-args.test:1
+## This test checks that an error is thrown in case of invalid input/output args.
+
----------------
jhenderson wrote:
> On further reflection, perhaps it makes sense to combine this and basic.test into a single test. What do you think?
Actually, ignore my previous comment, since basic.test is only short-term.

You'll probably want to add --static to these tests when you add support to that option to avoid any potential confusion.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82923/new/

https://reviews.llvm.org/D82923





More information about the llvm-commits mailing list