[PATCH] D83248: [NFCI][IR] Introduce CallBase::Create() wrapper
Roman Lebedev via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jul 6 12:24:46 PDT 2020
lebedev.ri marked 3 inline comments as done.
lebedev.ri added inline comments.
================
Comment at: llvm/include/llvm/IR/InstrTypes.h:1145
+ static CallBase *Create(CallBase *CB, ArrayRef<OperandBundleDef> Bundles,
+ Instruction *InsertPt = nullptr);
+
----------------
nickdesaulniers wrote:
> lebedev.ri wrote:
> > nickdesaulniers wrote:
> > > No call sites make use of this default value (`nullptr`). Is it the right value? I'm not sure if you can default it to `CB`, but if not, should it just be a required parameter with no default value?
> > This is a direct wrapper over all the subclasses `Create()` function with the same signature.
> > They all follow this pattern. I'm not sure why we should deviate here.
> Ah, I missed the use in the child patch.
Hm, that use wasn't supposed to be there.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D83248/new/
https://reviews.llvm.org/D83248
More information about the llvm-commits
mailing list