[PATCH] D82520: [Power10] Implement Vector Splat Immediate Builtins in LLVM/Clang

[Biplob Mishra via Phabricator via llvm-commits]

biplmish marked an inline comment as done.
biplmish added inline comments.


================
Comment at: clang/lib/Headers/altivec.h:17210
+
+static __inline__ vector double __ATTRS_o_ai vec_splatid(const float __a) {
+  return ((vector double)((double)__a));
----------------
amyk wrote:
> Move function name on next line for consistency.
These changes break the clang-format. 


================
Comment at: clang/test/CodeGen/builtins-ppc-p10vector.c:633
+vector signed int test_vec_vec_splati_si(void) {
+  // CHECK: ret <4 x i32> <i32 -17, i32 -17, i32 -17, i32 -17>
+  return vec_splati(-17);
----------------
lei wrote:
> missing CHECK-BE
vec_splati and vec_splati do not have an endianess specific implementation.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82520/new/

https://reviews.llvm.org/D82520