[PATCH] D83177: [llvm-reduce] Reducing call operand bundles

[Nick Desaulniers via Phabricator via llvm-commits]

nickdesaulniers added inline comments.


================
Comment at: llvm/lib/IR/Instructions.cpp:251
+CallBase *CallBase::Create(CallBase *CB, ArrayRef<OperandBundleDef> Bundles,
+                           Instruction *InsertPt) {
+  switch (CB->getOpcode()) {
----------------
unused param?


================
Comment at: llvm/tools/llvm-reduce/deltas/ReduceOperandBundles.cpp:34
+
+using namespace llvm;
+
----------------
if you move this up, then you don't need to wrap the forward declaration of `class Module` above.


================
Comment at: llvm/tools/llvm-reduce/deltas/ReduceOperandBundles.cpp:78
+
+  OperandBundleRemapper(ArrayRef<Chunk> ChunksToKeep) : O(ChunksToKeep) {}
+
----------------
`explicit` for one operand constructors?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83177/new/

https://reviews.llvm.org/D83177