[PATCH] D83046: [LiveDebugValues] 1/4 Install an implementation-picking LiveDebugValues pass

[Djordje Todorovic via Phabricator via llvm-commits]

djtodoro added inline comments.


================
Comment at: llvm/lib/CodeGen/CMakeLists.txt:184
 
+  LiveDebugValues/LiveDebugValues.cpp
   LiveDebugValues/VarLocBasedImpl.cpp
----------------
jmorse wrote:
> djtodoro wrote:
> > We can add new subdirectory here as:
> > `add_subdirectory(LiveDebugValues)`
> > 
> > and then, add another `CMakeLists.txt` with in `LiveDebugValues/` and play with all of this within that `CMake` file locally? wdyt?
> I've shied away from this due to being a CMake novice, but my understanding is we'd need to either:
>  * Append the sources to the "LLVMCodeGen" library sources list from inside that new CMakeLists.txt, or
>  * Define a new "llvm_component_library" for LiveDebugValues, which seems like overkill.
> 
> Referring to the source files from this CMakeList avoided me having to think about that; I can implement the first item if it's preferable for each directory to have a CMakeLists.txt.
I am OK with either way. If other folks do not have impression about that, this part is OK for me as well.

>Referring to the source files from this CMakeList avoided me having to think about that; I can implement the first item if it's preferable for each directory to have a CMakeLists.txt.
I am not sure we need that if we do not consider the item 2.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83046/new/

https://reviews.llvm.org/D83046