[PATCH] D83024: [PGO] Instrument function entry BB by default in IR PGO

Wei Mi via llvm-commits llvm-commits at lists.llvm.org
Sun Jul 5 22:58:49 PDT 2020


On Sun, Jul 5, 2020 at 10:13 PM David Li via Phabricator <
reviews at reviews.llvm.org> wrote:

> davidxl added a comment.
>
> The version number probably can be kept unchanged -- however there needs
> to be a new variant bit to indicate the choice.
>
> Changing version number does not work either -- suppose after the flip,
> user select the instr-entry=false, but the version number will still be 7
> -- this will lead to problem at profile-use time.
>

If compiler can relax the check about the consistency between the version
of profile to read and the version of current compiler as long as the
version is 6 or 7, may changing version number work?



>
>
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D83024/new/
>
> https://reviews.llvm.org/D83024
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200705/9a8b72ae/attachment.html>


More information about the llvm-commits mailing list