[PATCH] D83013: [LPM] Port CGProfilePass from NPM to LPM

Sun Jul 5 14:56:29 PDT 2020

zhizhouy added inline comments.

================
Comment at: llvm/tools/opt/opt.cpp:281

+static cl::opt<bool> EnableCallGraphProfile(
+    "enable-call-graph-profile", cl::init(true), cl::Hidden,
----------------
MaskRay wrote:
> If there is no strong need for tuning this, please delete the option and PassManagerBuilder::CallGraphProfile
> 
> -----
> 
> I know that `-enable-npm-call-graph-profile` exists, but it seems like a temporary workaround for me. @zhizhouy @void (D62627) Is the option still used?
Does GNU assembler recognize .cgprofile section now?

I think we should keep this option as long as there is still usage of other than integrated assembler.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83013/new/

https://reviews.llvm.org/D83013