[PATCH] D71673: [InstCombine] Improve infinite loop detection

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Jul 4 06:26:31 PDT 2020


lebedev.ri added inline comments.


================
Comment at: llvm/lib/Transforms/InstCombine/InstructionCombining.cpp:125-126
 
-static constexpr unsigned InstCombineDefaultMaxIterations = UINT_MAX - 1;
+static constexpr unsigned InstCombineDefaultMaxIterations = 1000;
+static constexpr unsigned InstCombineDefaultInfiniteLoopThreshold = 1000;
 
----------------
I'm guessing that the general understanding that ideally these should become `2` in the end.
Now, that might never happen, but that should be the trend.
So far no one seems to have come up with any cases where `1000` limit is reached.
Can we periodically ~halve them, starting now?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71673/new/

https://reviews.llvm.org/D71673





More information about the llvm-commits mailing list