[PATCH] D82821: [WebAssembly] Added 64-bit memory.grow/size/init/copy/fill

Thomas Lively via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 3 17:46:20 PDT 2020


tlively added inline comments.


================
Comment at: llvm/test/MC/WebAssembly/bulk-memory-encodings.s:10
-    # CHECK: data.drop 3 # encoding: [0xfc,0x09,0x03]
-    data.drop 3
-
----------------
Getting rid of the intrinsics and clang builtins is fine, but I think we should keep the instruction definitions and these tests around. They would still be useful for disassembling modules that contain these instructions in the linker-synthesized memory initialization function.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82821/new/

https://reviews.llvm.org/D82821





More information about the llvm-commits mailing list