[PATCH] D82481: [XCOFF][AIX] Give symbol an internal name when desired symbol name contains invalid character(s)

[Jason Liu via Phabricator via llvm-commits]

jasonliu added inline comments.


================
Comment at: llvm/lib/MC/MCContext.cpp:317
+  // as prefix to signal this is an renamed symbol.
+  const bool IsEntryPoint = InvalidName[0] == '.';
+  SmallString<128> ValidName =
----------------
hubert.reinterpretcast wrote:
> Don't try to access the first character without locally ensuring that the string is non-empty. For example, ICC produces an "internal error" (https://godbolt.org/z/zLiJqb). It seems Clang avoids generating such by diagnosing empty string literals used as `__asm__` names.
Thanks for the example and also trying it out with Clang.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82481/new/

https://reviews.llvm.org/D82481