[PATCH] D82479: [llvm-size] Output REL, RELA and STRTAB sections in some cases

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.

In D82479#2122112 <https://reviews.llvm.org/D82479#2122112>, @grimar wrote:

> This patch makes the output closer to GNU size, so LGTM.
>  I think intentional further deviation from the GNU output can be done separately (if we want it).


I think I don't feel too happy that the commit introduced complexity before we have a better understanding of GNU size's exact behaviors and before we reach a consensus that we do want to emulate GNU size in this (IMHO) very minor edge cases.

The motivation is not very clearly expressed.

`gnu size` should be GNU size.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82479/new/

https://reviews.llvm.org/D82479