[PATCH] D82365: [Power10] Implement Vector Insert Builtins in LLVM/Clang

[Lei Huang via Phabricator via llvm-commits]

lei added inline comments.


================
Comment at: clang/lib/Headers/altivec.h:16921
+
+static __inline__ vector unsigned long long __ATTRS_o_ai vec_insertl(
+    unsigned long long __a, vector unsigned long long __b, unsigned int __c) {
----------------
consistency.  bring `vec_insert..` to next line same as previous def.
same for all such below.


================
Comment at: llvm/lib/Target/PowerPC/PPCInstrPrefix.td:782
+    VXForm_VTB5_RA5_ins<15, "vinsbvlx",
+                       [(set v16i8:$vD,
+                             (int_ppc_altivec_vinsbvlx v16i8:$vDi, i64:$rA,
----------------
all these indentation is off by 1.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82365/new/

https://reviews.llvm.org/D82365