[PATCH] D82935: [llvm-objcopy] Fix crash when removing symbol table at same time as adding a symbol

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM, with one suggestion.

If you haven't already, you should be able to request commit access, as outlined in the docs.



================
Comment at: llvm/test/tools/llvm-objcopy/ELF/add-symbol-new-symtab.test:6
+# RUN: llvm-objcopy -R .symtab --add-symbol newsym=1234 %t %t2
+# RUN: llvm-readelf -S -s %t2 | FileCheck %s
+
----------------
Add `--match-full-lines` to the FileCheck call. This will prevent there being spurious data at the end of the line. For example, if a section's alignment were 16, a check of 1 would still pass, because FileCheck only does partial matches by default.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82935/new/

https://reviews.llvm.org/D82935