[PATCH] D82973: [InstCombine] Try to narrow expr if trunc cannot be removed.

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 3 05:21:28 PDT 2020


lebedev.ri added inline comments.


================
Comment at: llvm/lib/Transforms/InstCombine/InstCombineCasts.cpp:723
+      auto *NewDestTy = DestITy->getExtendedType();
+      if (shouldChangeType(SrcTy, DestTy) &&
+          canEvaluateTruncated(Src, NewDestTy, *this, &Trunc)) {
----------------
spatel wrote:
> DestTy should be NewDestTy here?
Still reads as `DestTy` to me


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82973/new/

https://reviews.llvm.org/D82973





More information about the llvm-commits mailing list