[PATCH] D83107: [flang] Add FIR builder

Jean Perier via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 3 01:03:16 PDT 2020


jeanPerier accepted this revision.
jeanPerier added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: flang/lib/Lower/FIRBuilder.cpp:144
+    return val;
+  // FIXME: add a fir::is_integer() test
+  ComplexExprHelper helper{*this, loc};
----------------
There is a `fir::isa_integer` in FIRType.h now, I do not think it is up-streamed yet, but maybe it could be upstreamed with this patch if it is easy. I am fine with leaving this for a later upstream otherwise.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83107/new/

https://reviews.llvm.org/D83107





More information about the llvm-commits mailing list