[PATCH] D83085: DomTree: Remove getRoots() accessor

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 2 18:53:45 PDT 2020


arsenm accepted this revision.
arsenm added a comment.
This revision is now accepted and ready to land.

This is more consistent with other iteratables



================
Comment at: llvm/unittests/IR/DominatorTreeTest.cpp:808
   EXPECT_TRUE(PDT.verify());
-  EXPECT_TRUE(PDT.getRoots().size() == 2);
+  EXPECT_TRUE(PDT.root_size() == 2);
   // Make sure we can use a const pointer with getNode.
----------------
This should really be EXPECT_EQ(2, PDT.root_size())


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83085/new/

https://reviews.llvm.org/D83085





More information about the llvm-commits mailing list