[PATCH] D82481: [XCOFF][AIX] Give symbol an internal name when desired symbol name contains invalid character(s)

[Hubert Tong via Phabricator via llvm-commits]

hubert.reinterpretcast added inline comments.


================
Comment at: llvm/include/llvm/MC/MCStreamer.h:580
+  ///
+  /// \param Name - The Internal reference to the symbol.
+  /// \param Rename - The value to which the Name parameter is changed at end of
----------------
I would suggest not to capitalize "Internal" if there is no clear special definition of that word that this is referencing.

Suggestion:
The name used internally in the assembly for references to the symbol.


================
Comment at: llvm/include/llvm/MC/MCStreamer.h:581
+  /// \param Name - The Internal reference to the symbol.
+  /// \param Rename - The value to which the Name parameter is changed at end of
+  /// assembly.
----------------
s/at end/at the end/;


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82481/new/

https://reviews.llvm.org/D82481