[PATCH] D81929: [WIP][Attributor] Introduce CallBaseContext to the IRPosition

[Kuter Dinel via Phabricator via llvm-commits]

kuter added a comment.

In D81929#2129517 <https://reviews.llvm.org/D81929#2129517>, @jdoerfert wrote:

> In D81929#2129334 <https://reviews.llvm.org/D81929#2129334>, @kuter wrote:
>
> > In D81929#2128955 <https://reviews.llvm.org/D81929#2128955>, @jdoerfert wrote:
> >
> > > In D81929#2096257 <https://reviews.llvm.org/D81929#2096257>, @jdoerfert wrote:
> > >
> > > > We need some way of testing this, so tests that enable this and some way of checking the output. We could look for the debug output or add some other way of checking
> > >
> > >
> > > Reverse ping. Unit tests might also be an option.
> >
> >
> > Wouldn't just testing the uses of this path enough.
> >  For example if we have are getting a correct call site constant range would that be enough ?
>
>
> Is the CBContext already used? I might have to take another look at this, sorry.


Not by this patch no. But I have patches that use CBContext(That I am going to send to phabricator soon).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81929/new/

https://reviews.llvm.org/D81929