[PATCH] D83099: Revert "[clangd] Store index in '.clangd/index' instead of '.clangd-index'"

Sam McCall via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 2 15:08:30 PDT 2020


sammccall created this revision.
sammccall added reviewers: kadircet, hokein.
Herald added subscribers: llvm-commits, cfe-commits, usaxena95, arphaman, omtcyfz, jkorous, MaskRay, ilya-biryukov.
Herald added projects: clang, LLVM.

This was well-intentioned, but it turns out `.clangd` is the best
filename for the clangd config file (matching .clang-format and .clang-tidy).
And of course we can't have both .clangd/index and .clangd...

So lacking better ideas, back to .clangd-index we go.
The monorepo gitignore is updated to reflect the new best-practice:

  ignore .clangd/ (with trailing slash) matching index files from clangd 9/10
  ignore .clangd-index/ matching index files from clangd <=8 and 11+.

The entries from llvm-project/llvm gitignore are removed (obsolete).

This reverts commit 2754942cbaef0b72c178e34247611521382c361c.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D83099

Files:
  .gitignore
  clang-tools-extra/clangd/index/Background.h
  clang-tools-extra/clangd/index/BackgroundIndexStorage.cpp
  clang-tools-extra/clangd/test/background-index.test
  llvm/.gitignore

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D83099.275244.patch
Type: text/x-patch
Size: 4269 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200702/9877ce01/attachment.bin>


More information about the llvm-commits mailing list