[PATCH] D82995: [UpdateTestChecks] Allow $ in function names

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 2 15:08:27 PDT 2020


spatel added a comment.

It would be good to check in a test example alongside this change, so we know it works. (And we'll know what we are losing if this has to be reverted for some reason.)



================
Comment at: llvm/utils/UpdateTestChecks/asm.py:122
 
 ASM_FUNCTION_ARM_MACHO_RE = re.compile(
      r'^_(?P<func>[^:]+):[ \t]*\n'
----------------
Do these ARM regexes not need the extra '?' like the others?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82995/new/

https://reviews.llvm.org/D82995





More information about the llvm-commits mailing list