[PATCH] D82203: [FileCheck] Implement -dump-input-context

[Joel E. Denny via Phabricator via llvm-commits]

jdenny updated this revision to Diff 275237.
jdenny retitled this revision from "[FileCheck] Implement -dump-input-context and -dump-input-filter" to "[FileCheck] Implement -dump-input-context".
jdenny edited the summary of this revision.
jdenny added a comment.

I've split this review into three:

- D83091 <https://reviews.llvm.org/D83091>: [FileCheck] Improve -dump-input documentation: This extracts some documentation changes that stand on their own.
- D82203 <https://reviews.llvm.org/D82203>: [FileCheck] Implement -dump-input-context: This is the current review.  I've removed `-dump-input-filter` so we can decide whether it's worthwhile separately.  I've kept `-dump-input-context`.  I think it is frequently useful, it adds very little complexity to the implementation and interface, and it actually seems to make testing the elision of the input easier.
- D83097 <https://reviews.llvm.org/D83097>: [FileCheck] Implement -dump-input-filter

For the first and third reviews, I've added only a subset of the reviewers here as this review is the focus, but obviously everyone is welcome on all three.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82203/new/

https://reviews.llvm.org/D82203

Files:
  llvm/test/FileCheck/dump-input-annotations.txt
  llvm/test/FileCheck/dump-input-context.txt
  llvm/test/FileCheck/dump-input-enable.txt
  llvm/test/FileCheck/dump-input-filter.txt
  llvm/utils/FileCheck/FileCheck.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D82203.275237.patch
Type: text/x-patch
Size: 32008 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200702/2531dce6/attachment-0001.bin>