[PATCH] D82961: [Scalarizer] Variable insert handling (PR46524)

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 2 10:47:52 PDT 2020


arsenm added a comment.

In D82961#2128464 <https://reviews.llvm.org/D82961#2128464>, @jdoerfert wrote:

> I like the flag idea, but I would expect this to be the default. If I read scalarizer and I enable it, I would expect the code to be scalarized, not partially scalarized based on a heuristic that may or may not be to my liking. The option to opt-out of some scalarization is sensible though.


You have a different idea of what scalarization means than I do. I want to eliminate operations on vectors; I consider this as arithmetic operations operating on vectors. An insertelement/extractelement is not really a vector operation itself.

For AMDGPU we can implement dynamic indexing by directly indexing the registers without splitting this into a long chain of operations or introducing stack use


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82961/new/

https://reviews.llvm.org/D82961





More information about the llvm-commits mailing list