[PATCH] D70365: intrinsics attribute opt-out list proposal.

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added a comment.

In D70365#2123539 <https://reviews.llvm.org/D70365#2123539>, @efriedma wrote:

> > One way to avoid some of the complexity would be to opt-out of everything with a single bit. So if this is set, you don't get any default attributes. Otherwise you get all.
>
> Probably depends on what the initial list looks like.  I guess something like "nosync, norecurse, nounwind, willreturn" is reasonable for most intrinsics.  Given that list, probably an intrinsic that wants to opt-out of one of those will want to opt-out of all of them.


That was what I would expect too. The above list might be extended with `nofree` but conceptually we might want to start with a single boolean to opt-out of everything. As we move on, we might go for a list or "categories", let's see.

@sstefan1 could u update the patch? We then send another email out with the list of 5 attributes we will make opt-out for intrinsics. A week or so later, assuming no one objected too much, we'll land it. In the meantime we need to update the target independent ones to opt-out appropriately. I guess my nosync list will catch almost all of them already but we'll have to give it another go as the patch is updated. WDYT?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70365/new/

https://reviews.llvm.org/D70365