[PATCH] D83043: [DebugInfo] Use Cursor to detect errors in debug line prologue parser

Pavel Labath via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 2 06:57:47 PDT 2020


labath accepted this revision.
labath added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFDebugLine.cpp:404-407
     for (uint32_t I = 1; I < OpcodeBase; ++I) {
-      uint8_t OpLen = DebugLineData.getU8(OffsetPtr);
+      uint8_t OpLen = DebugLineData.getU8(Cursor);
       StandardOpcodeLengths.push_back(OpLen);
     }
----------------
Maybe `DebugLineData.getU8(Cursor, StandardOpcodeLengths.begin(), OpcodeBase-1)`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83043/new/

https://reviews.llvm.org/D83043





More information about the llvm-commits mailing list