[PATCH] D82524: [SVE][CodeGen] Fix bug when falling back to DAG ISel

[David Sherwood via Phabricator via llvm-commits]

david-arm marked 2 inline comments as done.
david-arm added inline comments.


================
Comment at: llvm/lib/Target/AArch64/GISel/AArch64CallLowering.cpp:431
+bool AArch64CallLowering::fallBackToDAGISel(const Function &F) const {
+  for (const auto &Arg : F.args()) {
+    if (isa<ScalableVectorType>(Arg.getType()))
----------------
sdesmalen wrote:
> Should this function also check the return value?
> 
> nit: use `llvm::any_of` instead of a loop?
Strictly speaking we didn't have to catch the return value here as it was being caught by the ret instruction, however it is a nice optimisation to catch it early on here so I've added the check.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82524/new/

https://reviews.llvm.org/D82524