[PATCH] D82970: [Scalarizer] Variable insert handling (PR46524)

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri marked 2 inline comments as done.
lebedev.ri added a comment.

In D82970#2126905 <https://reviews.llvm.org/D82970#2126905>, @arsenm wrote:

> I think this maybe should be a pass option


I can make it an option, but since it's not actually currently yet enabled
in default pipelines i'd maybe like to hear from the authors
and/or those who have it enabled in their pipelines.
Makes sense?



================
Comment at: llvm/lib/Transforms/Scalar/Scalarizer.cpp:777
+  VectorType *VT = dyn_cast<VectorType>(EEI.getOperand(0)->getType());
+  if (!VT)
+    return false;
----------------
arsenm wrote:
> Does this need to worry about scalable vectors?
Likely. I think that worry is pass-wide,
so i'm just gonna follow the existing pattern.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82970/new/

https://reviews.llvm.org/D82970