[PATCH] D82974: [DebugInfo] Allow GNU macro extension to be read

Igor Kudrin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 2 00:29:39 PDT 2020


ikudrin added inline comments.


================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFDebugMacro.cpp:57
+        WithColor(OS, HighlightColor::Macro).get()
+            << MacroString(E.Type, /*GNU=*/Macros.Header.Version < 5);
       else
----------------
If this is written like
```
<< (Macros.Header.Version < 5 ? GnuMacroString(E.type) : MacroString(E.type)) ;
```

then `llvm::dwarf::MacroString()` can be left as is and most of the changes are not needed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82974/new/

https://reviews.llvm.org/D82974





More information about the llvm-commits mailing list