[PATCH] D82826: [X86] support .nops directive

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/lib/Target/X86/MCTargetDesc/X86AsmBackend.cpp:1073
+unsigned X86AsmBackend::getMaximumNopSize() const {
+  if (STI.getFeatureBits()[X86::Mode32Bit])
+    return 2;
----------------
Mode32Bit is only relevant if FeatureNOPL is false. So I think it should be

  if (!STI.getFeatureBits()[X86::FeatureNOPL] &&
      !STI.getFeatureBits()[X86::Mode64Bit])
    return STI.getFeatureBits()[X86::Mode32Bit] ? 2 : 1;


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82826/new/

https://reviews.llvm.org/D82826