[PATCH] D82923: introducing llvm-libtool-darwin

Wed Jul 1 16:45:32 PDT 2020

MaskRay added inline comments.

================
Comment at: llvm/test/tools/llvm-libtool-darwin/help-message.test:5
+# RUN: llvm-libtool-darwin --help | FileCheck --check-prefix=LIBTOOL-USAGE %s --match-full-lines
+# RUN: not llvm-libtool-darwin -abcabc 2>&1 | FileCheck --check-prefix=UNKNOWN-ARG %s
+# RUN: not llvm-libtool-darwin --abcabc 2>&1 | FileCheck --check-prefix=UNKNOWN-ARG %s
----------------
Does cctool libtool use `-long-option` as the canonical spelling?

For comparison, GNU getopt convention is `--long-option`

================
Comment at: llvm/tools/llvm-libtool-darwin/LLVMBuild.txt:20
+parent = Tools
+required_libraries = Object Option Support
----------------
Have you tried a `-DBUILD_SHARED_LIBS=on` cmake build and ensured `ninja llvm-libtool-darwin` can build? `-DBUILD_SHARED_LIBS=on` sometimes has stricter dependency requirement. Every direct dependency must be listed to make `-z defs` happy.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82923/new/

https://reviews.llvm.org/D82923